Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new-log-viewer: Add
NotificationContextProvider
for managing pop-up messages; add pop-ups for errors and remove status bar dummy message. #84new-log-viewer: Add
NotificationContextProvider
for managing pop-up messages; add pop-ups for errors and remove status bar dummy message. #84Changes from 44 commits
61f4b6e
fc5fbc3
4e2ae14
93e4a3d
3a69b71
43b7378
e8ce67a
0df2470
d0ab264
68f9bfd
670cf09
957f5a0
306cc25
0c30d20
83f5007
fc37786
18c75e4
e346322
d44d073
3a63386
db134b5
729fac6
93ab288
2c92af5
4c51ff2
f4d191a
fe57144
d8d997d
4704393
7881cb5
ddbb577
4635798
d81e258
62409b0
7b71ac4
779d93b
143a4bb
2dec93b
38cafbd
189be81
c81d38c
ac0ee35
e107a94
de99ef3
6980c7a
df5be3b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider using relative units for width
The
.pop-up-message-box-alert-layout
class sets a fixed width for the alert box. While this ensures consistency, it might not be ideal for all screen sizes.Consider using relative units (like percentages or
rem
) or a combination ofmin-width
andmax-width
to make the layout more responsive. For example:This approach would maintain the desired size on larger screens while adapting to smaller screens.