Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting: Upgrade to latest version of yscope-dev-utils and add C++ lint configs from yscope-dev-utils. #537

Merged
merged 10 commits into from
Sep 13, 2024

Conversation

kirkrodrigues
Copy link
Member

@kirkrodrigues kirkrodrigues commented Sep 12, 2024

Description

This PR:

  • upgrades to the latest version of yscope-dev-utils.
  • adds a task to symlink the C++ link configs from yscope-dev-utils.
  • updates the existing .clang-format to inherit from the symlinked configs and only override project-specific settings.

Validation performed

  • task lint:check showed no violations
  • Added a format violation to components/core/src/clp/ir/LogEventDeserializer.hpp
    • task lint:check detected it.
    • task lint:fix fixed it.
  • Validated that a CLion project inside components/core used .clang-tidy symlinked at the root of the project as follows:
  • Validated that yscope-dev-utils could be downloaded successfully in a source-only release as follows:
    • Clone the repo.
    • Delete the .git directory.
    • Run ./tools/scripts/deps-download/init.sh.
    • Run task lint:check and observe no failures.
    • Check that .clang-format and .clang-tidy are symlinked at the root of the repo.

@kirkrodrigues kirkrodrigues merged commit 3ceb17e into y-scope:main Sep 13, 2024
17 checks passed
@kirkrodrigues kirkrodrigues deleted the cpp-lint-configs branch September 13, 2024 16:05
gibber9809 pushed a commit to gibber9809/clp that referenced this pull request Oct 25, 2024
jackluo923 pushed a commit to jackluo923/clp that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants