Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest commit of CLP core; Fix the scope of what's considered a system header. #7

Merged
merged 12 commits into from
Jul 5, 2024

Conversation

LinZhihao-723
Copy link
Member

References

Description

This PR updates clp core dependency to the latest commit. It contains the following changes:

  1. Update on the build system config files for CMake and bazel to adapt source file structure changes in clp core
  2. Update implementations in the Go ffi source files to adapt namespace and API changes in clp core ffi.

Note:
The latest clp commit has the IR format updated with UTC offset change packet. This PR doesn't handle the latest format yet (in both serializer and deserializer); another PR is expected after this PR gets merged to add support for UTC offset changes.

Validation performed

  1. Workflow passed with both cmake and bazel build succeeded
  2. Passed all the linter checks

cpp/src/ffi_go/ir/deserializer.cpp Outdated Show resolved Hide resolved
cpp/src/ffi_go/search/wildcard_query.cpp Outdated Show resolved Hide resolved
@LinZhihao-723 LinZhihao-723 requested a review from davidlion July 4, 2024 19:23
davidlion
davidlion previously approved these changes Jul 5, 2024
@davidlion davidlion changed the title Update clp core dependency to the latest OSS commit. Update to the latest commit of CLP core; Fix the scope of what's considered a system header. Jul 5, 2024
@davidlion davidlion merged commit c565ab8 into y-scope:main Jul 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants