Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to use DependencyPropertyAttribute #418

Merged
merged 1 commit into from
Dec 24, 2023
Merged

Conversation

y-iihoshi
Copy link
Owner

Closes #417.

Copy link

codecov bot commented Dec 24, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e7ba961) 81.90% compared to head (3e132d7) 81.58%.

Files Patch % Lines
...nverter/Interactivity/FolderBrowserDialogAction.cs 66.66% 0 Missing and 1 partial ⚠️
...oreFileConverter/Interactivity/FontDialogAction.cs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
- Coverage   81.90%   81.58%   -0.32%     
==========================================
  Files         472      471       -1     
  Lines       16367    16094     -273     
  Branches     1250     1252       +2     
==========================================
- Hits        13405    13130     -275     
  Misses       2879     2879              
- Partials       83       85       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@y-iihoshi y-iihoshi merged commit 572c0b7 into main Dec 24, 2023
13 of 17 checks passed
@y-iihoshi y-iihoshi deleted the fix-dependency-properties branch December 24, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to DependencyPropertyGenerator
1 participant