Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yrs 0.21.3 dep upgrade #156

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

alexlopashev
Copy link

No description provided.

@alexlopashev alexlopashev changed the title alexlopashev/yrs 0.21.3 dep upgrade yrs 0.21.3 dep upgrade Dec 30, 2024
src/y_map.rs Outdated Show resolved Hide resolved
@davidbrochart
Copy link
Collaborator

FYI ypy is not maintained anymore. See pycrdt instead.

@alexlopashev
Copy link
Author

FYI ypy is not maintained anymore. See pycrdt instead.

Hi @davidbrochart, in fact this is PR to revive this library, and I'm volunteered to be new maintainer.

@davidbrochart
Copy link
Collaborator

Maybe ping Kevin in #148?

@alexlopashev
Copy link
Author

Maybe ping Kevin in #148?

I've reached out directly over email couple weeks ago, but good point, will report on the issue as well, thanks!

src/y_array.rs Outdated Show resolved Hide resolved
src/y_doc.rs Show resolved Hide resolved
@alexlopashev
Copy link
Author

@Horusiath @dmonad

Unless there are other suggestions, I believe this change set is ready to be merged and published.

}
SharedType::Prelim(_) => Err(PreliminaryObservationException::default_message()),
}
}

/// Cancels the callback of an observer using the `observation_d` returned from the `observe` method.
pub fn unobserve(&mut self, observation_d: ObservationId) -> PyResult<bool> {
pub fn unobserve(&mut self, observation_d: ObservationId) -> PyResult<()> {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't be better to implement close method on ObservationId? This way you could potentially use it in with statements. Not a single thing in unobserve method requires self to be a param either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants