Add squashed update after deleting document history #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbrochart
force-pushed
the
fix_ttl
branch
from
cb92101 to
c97b1fd
Compare
dlqqq
suggested changes
Nov 23, 2022
There was a problem hiding this comment.
It looks like the "diff > document_ttl" case is getting pretty expensive to handle now, so we'll definitely want to run this in a separate asyncio task like @ellisonbg suggested. We'd bind this to an instance attribute, and on every document write, we cancel any existing task and create a new task that sleeps for document_ttl and then runs this squash logic.
But, this can be done in a follow-up PR.
| async with aiosqlite.connect(ystore.db_path) as db: | ||
| assert (await (await db.execute("SELECT count(*) FROM yupdates")).fetchone())[ | ||
| 0 | ||
| ] == i + 1 | ||
|
|
||
| # assert that adding a record after document TTL deletes previous document history |
There was a problem hiding this comment.
Suggested change
| # assert that adding a record after document TTL deletes previous document history | |
| # assert that adding a record after document TTL squashes previous document history |
| await db.execute("DELETE FROM yupdates WHERE path = ?", (self.path,)) | ||
| # insert squashed updates | ||
| squashed_update = Y.encode_state_as_update(ydoc) | ||
| metadata = await self.get_metadata() |
There was a problem hiding this comment.
Can we lift this definition out of the if block so it's not evaluated again on line 256?
There was a problem hiding this comment.
I don't think so, as the metadata can depend on time, for instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #50 (comment).