Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implement support for Selectors Level 4, Reference combinators. #1

Closed
wants to merge 1 commit into from

Conversation

xzyfer
Copy link
Owner

@xzyfer xzyfer commented Oct 6, 2014

This PR prevents libsass from barfing when it encounters the reference combinator from CSS Selectors Level 4.

Fixes sass#452. Spec added sass/sass-spec#57.

A couple things to note

For intents and purposes the /deep/ combinator acts like the direct sibling combinator except for the shadow dom. 3.2.4 Selecting Through Shadows: the /deep/ combinator.

Note

This is still heavily a work in progress. A PR will be opened against sass/libsass when ready.

@xzyfer xzyfer changed the title Don't error when encountering the deep combinator [WIP] Implement support for Selectors Level 4, Reference combinators. Oct 6, 2014
@matthiasbayer
Copy link

Great work!

@xzyfer
Copy link
Owner Author

xzyfer commented Jul 10, 2017

Reference combinator support has been removed from Sass.
sass/sass#2317

@xzyfer xzyfer closed this Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Shadow DOM styling
2 participants