Checking if function failed before deciding to progress checkpointer #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a function app fails internally, the EventHubTrigger will throw away events, because the exception is treated as user code.
See:
Azure/azure-webjobs-sdk#2432
Azure/azure-functions-host#5240
This PR prevents events getting thrown away, by not progressing the checkpointer in case of exceptions. Code assumes, that the user will handle user exceptions manually in the Run function.
Code should be refactored to allow the user to choose the flow, in host.json or the local settings file.
MyGet package for this branch:
https://www.myget.org/feed/xzuttz/package/nuget/Microsoft.Azure.WebJobs.Extensions.EventHubs