Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output path not being created recursively #14

Closed
filipesilva opened this issue Aug 2, 2017 · 3 comments
Closed

Output path not being created recursively #14

filipesilva opened this issue Aug 2, 2017 · 3 comments
Assignees
Labels

Comments

@filipesilva
Copy link
Contributor

Heya,

If the webpack configuration has a deep output path that doesn't currently exist, license-webpack-plugin will fail at mkdirSync (angular/angular-cli#7203).

Webpack itself is ok with creating this path and putting files there though. Perhaps compilation.assets could be used instead of mkdirSync? There's an example at https://github.com/webpack/docs/wiki/how-to-write-a-plugin#a-simple-example where they do that. That way Webpack itself would take care of outputting it.

@xz64 xz64 self-assigned this Aug 2, 2017
@xz64 xz64 added the bug label Aug 2, 2017
@xz64
Copy link
Owner

xz64 commented Aug 2, 2017

In order to get access to the compilation object I will need to refactor the plugin to hook into the emit phase of webpack. I will try out your suggestion.

@xz64
Copy link
Owner

xz64 commented Aug 6, 2017

@filipesilva I have pushed some updates to the dev branch. Please try it out and let me know if you run into any issues. There is a migration guide at MIGRATION.md for some breaking changes.

@filipesilva
Copy link
Contributor Author

Hi @xz64, I can confirm that using the dev branch this bug does not manifest anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants