Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge chiron-6 build updates #98

Merged
merged 13 commits into from
Oct 6, 2018
Merged

Merge chiron-6 build updates #98

merged 13 commits into from
Oct 6, 2018

Conversation

panesofglass
Copy link
Contributor

@panesofglass panesofglass commented Oct 1, 2018 •
edited
Loading

Seems like a rebase may be in order here, but I thought I would at least push this up for review.

Current issues/improvements:

  • version is retrieved from src/Directory.Build.props rather than hard-coded
  • Benchmarks are not currently run in AppVeyor build and fail to compile
  • Build fails on Travis apparently due to source link

@panesofglass
Copy link
Contributor Author

cc @ctaggart

@ctaggart
Copy link
Contributor

ctaggart commented Oct 1, 2018

@panesofglass Use a newer SDK. I suggest:
https://github.com/giraffe-fsharp/Giraffe/blame/master/.travis.yml#L5

@ctaggart ctaggart mentioned this pull request Oct 2, 2018
Open
@panesofglass panesofglass merged commit dd2d339 into xyncro:master Oct 6, 2018
@panesofglass panesofglass deleted the merge-chiron-6 branch October 6, 2018 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolektiv kolektiv Awaiting requested review from kolektiv

@neoeinstein neoeinstein Awaiting requested review from neoeinstein

@ninjarobot ninjarobot Awaiting requested review from ninjarobot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@panesofglass @ctaggart @ninjarobot @neoeinstein @tachyus-ryan