chore(NA): adds explicit browser, node and default exports resolution #4772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7f670ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thank you so much for this PR! This saved us a lot of time! I tested this export configuration with React 17 & 18, with What a mess this whole thing is... 😄 |
Merged
|
@peterkogo thank you so much for taking a look into this. I'm confident this will be enough to solve the problem. Unfortunately feels like currently the ecosystem is in a transition state so we got to live with this mess for a while 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows up on what was done at #4755.
Even having into account the changes in the previous PR, webpack v5 still resolves
@xyflow/react/dist/esm/index.mjswhich then tries to resolvereact/jsx-runtimewithin (and in that case it loaded from a .mjs which needs to bereact/jsx-runtime.js).The changes I'm proposing introduces a more explicit split in the resolution without room for wrong resolves going further.
\cc @peterkogo @moklick