add url pattern validation and additional buttons #84
+121
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-klein
commented
Nov 15, 2024
| * | ||
| * NOTE(spk): not all JavaScript regular expression characters are not supported in input patterns. | ||
| */ | ||
| export const urlPattern = String.raw`^(?:https|http):\/\/[^ ]+$` |
There was a problem hiding this comment.
I kept this on the conservative side, since a lack of a protocol or protocol mangling are the most common issues. This does tightly scope our <BaseInput type="url" /> to Website URL's, but that appears to be our only use case, and I can't remember the last time I needed to support another protocol.
However, you can always reach for type="text" with a custom pattern. ex: <BaseInput type="text" pattern="^(?:sftp|ftp):\/\/[^ ]+$" />
steven-klein
commented
Nov 15, 2024
| <!-- disabled --> | ||
| <button class="xy-btn-alt-sm" disabled>Button Text</button> | ||
| <button class="xy-btn-alt" disabled>Button Text</button> | ||
| <button class="xy-btn-alt-lg" disabled>Button Text</button> |
There was a problem hiding this comment.
We're close to 100% parity on button styles with marketing at this point, so I don't expect much more to show up here until an emerald/sapphire rebrand bomb drops.
steven-klein
requested review from
seedifferently,
profsmallpine and
DavidLarsKetch
DavidLarsKetch
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
<BaseInput type="url" />[DEV-2930]