Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add datetime-local to RFC 3339 handling in BaseInput #60

Closed
wants to merge 1 commit into from

Conversation

steven-klein
Copy link
Collaborator

What this does

  • handles read/write v-model transformation when BaseInput is type=datetime-local

Note

[email protected] ships with custom v-model modifiers and a defineModel macro, which might be a cleaner long term path, but I don't expect many more of these kinds of two-way transforms being necessary, so I'd rather ship something out now, and look more closely at defineModel + useModal before reaching for them.

@steven-klein
Copy link
Collaborator Author

@DavidLarsKetch I believe this will handle datetime-local inputs. npm install @xy-planning-network/trees@dev if you want to do a quick test.

Copy link
Collaborator

@DavidLarsKetch DavidLarsKetch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't been able to force any bugs, so the transforming is working well. If we opt to not go with a custom component then 👍 on merging this PR.

@steven-klein
Copy link
Collaborator Author

closing in favor of #61

@steven-klein steven-klein deleted the spk/datetime-local-modifier branch August 30, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants