adds SESSION_DOMAIN for specifying the domain to set on session cookies #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidLarsKetch
requested review from
seedifferently,
steven-klein and
profsmallpine
|
|
steven-klein
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
LGTM. I configured my local environment with this branch and #1527 and was able to observe a session cookie set on .xyplanningnetwork.test and the currentUser was set in the page props.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for Portal's cookie to be sent in requests to
connect.xyplanningnetwork.com, we need to set the cookie for our rootxyplanningnetwork.comdomain. Thataways, event handlers for Find an Advisor features can be aware ofcurrentUser(cf. Notion ticket).This PR adds
SESSION_DOMAINfor enabling this configuration.