sentry v0.11.0 -> v0.28.1; resolves http/resp.GenericErr skip frame bug #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidLarsKetch
requested review from
seedifferently,
steven-klein and
profsmallpine
|
I think I overestimated what Sentry was going to do with error unwrapping, but it doesn't appear to change anything about our usage. So, at least we're now current on our sdk version. |
DavidLarsKetch
commented
Aug 20, 2024
| Dsn: dsn, | ||
| Environment: env.String(), | ||
| IgnoreErrors: []string{"write: broken pipe"}, | ||
| MaxErrorDepth: 2, |
There was a problem hiding this comment.
It doesn't appear we wrap more than twice in our projects, so this seems like a sane default in line with Sentry's advice to keep it brief.
I also didn't see a change in exception handling when I wrapped a bunch of errors and changed this number, so 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump that sentry version up.
There's a small bug with
http/resp.GenericErrthat it captures the responder pkg's frame forGenericErrinstead of the frame before it, which would be the caller's frame. This PR resolves that.