Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dup2 on FreeBSD aarch64 #96

Closed
wants to merge 1 commit into from
Closed

Use dup2 on FreeBSD aarch64 #96

wants to merge 1 commit into from

Conversation

MikaelUrankar
Copy link

Hi,

I have the following errors on FreeBSD aarch64 :
logging/logging_arm64.go:11:2: undefined: syscall.Dup3

Is it possible to bump gopsutil version? It's a bit old and doesn't have the FreeBSD aarch64 bits:

# github.com/shirou/gopsutil/cpu
vendor/github.com/shirou/gopsutil/cpu/cpu_freebsd.go:25:16: undefined: cpuTimes
vendor/github.com/shirou/gopsutil/cpu/cpu_freebsd.go:42:31: undefined: cpuTimes
vendor/github.com/shirou/gopsutil/cpu/cpu_freebsd.go:66:38: undefined: cpuTimes
vendor/github.com/shirou/gopsutil/cpu/cpu_freebsd.go:72:15: undefined: cpuTimes
vendor/github.com/shirou/gopsutil/cpu/cpu_freebsd.go:87:13: undefined: cpuTimes
# github.com/shirou/gopsutil/disk
vendor/github.com/shirou/gopsutil/disk/disk_freebsd.go:26:36: undefined: MNT_WAIT
vendor/github.com/shirou/gopsutil/disk/disk_freebsd.go:31:15: undefined: Statfs
vendor/github.com/shirou/gopsutil/disk/disk_freebsd.go:32:28: undefined: MNT_WAIT
vendor/github.com/shirou/gopsutil/disk/disk_freebsd.go:38:17: undefined: MNT_RDONLY
vendor/github.com/shirou/gopsutil/disk/disk_freebsd.go:41:17: undefined: MNT_SYNCHRONOUS
vendor/github.com/shirou/gopsutil/disk/disk_freebsd.go:44:17: undefined: MNT_NOEXEC
vendor/github.com/shirou/gopsutil/disk/disk_freebsd.go:154:9: undefined: Bintime
vendor/github.com/shirou/gopsutil/disk/disk_freebsd.go:163:22: undefined: Statfs
vendor/github.com/shirou/gopsutil/disk/disk_freebsd.go:167:54: undefined: Statfs
vendor/github.com/shirou/gopsutil/disk/disk_freebsd.go:182:32: undefined: Devstat
vendor/github.com/shirou/gopsutil/disk/disk_freebsd.go:44:17: too many errors

Thanks!

@xxxserxxx
Copy link
Owner

I had to pin gopsutil because of some breakage when I let it update a few weeks ago; I may even have filed a bug on gopsutil, but I'll try it again this weekend and see if it works any better.

As for the pull request: first, thanks! I'll merge it after I can actually test FreeBSD builds this weekend; it didn't occur to me until yesterday that I could run FreeBSD in VMWare and test gotop there.

@xxxserxxx
Copy link
Owner

@MikaelUrankar , gopsutil 2.20 has problems building on FreeBSD, so I'm going to have to roll it back.

See this build for more information.

@xxxserxxx
Copy link
Owner

Turns out it wasn't a gopsutil issue, but rather an x/sys/util upstream API break (shirou/gopsutil#853). I'm rolling it back-back, because I still can't remember what broke that caused me to pin it at 2.18. gopsutil 2.20.x seems to be stable, on Linux, in any case.

@xxxserxxx
Copy link
Owner

This has been merged on v3.5 and master.

@xxxserxxx xxxserxxx closed this May 28, 2020
@MikaelUrankar
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants