Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused import and go mod tidy #151

Closed
wants to merge 2 commits into from
Closed

Conversation

hamdouni
Copy link

Just a quick fix to remove the "widgets" import that seams to be double, and put some "indirect" on go.mod to please go mod tidy :-)

@@ -7,12 +7,12 @@ require (
github.com/gizak/termui/v3 v3.1.0
github.com/go-ole/go-ole v1.2.4 // indirect
github.com/mattn/go-runewidth v0.0.4
github.com/nsf/termbox-go v0.0.0-20200418040025-38ba6e5628f1
github.com/nsf/termbox-go v0.0.0-20200418040025-38ba6e5628f1 // indirect
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was manually pinned because newer versions of termbox-go break FreeBSD; see a1bd0cc

github.com/shibukawa/configdir v0.0.0-20170330084843-e180dbdc8da0
github.com/shirou/gopsutil v2.20.3+incompatible
github.com/stretchr/testify v1.4.0
github.com/xxxserxxx/opflag v1.0.5
golang.org/x/sys v0.0.0-20200316230553-a7d97aace0b0
golang.org/x/sys v0.0.0-20200316230553-a7d97aace0b0 // indirect
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was also pinned to a specific version -- see e72e7be

Copy link
Owner

@xxxserxxx xxxserxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. The two "indirects" were removed because the versions were manually pinned to those versions in previous commits.

@hamdouni
Copy link
Author

Ok, thanks for the context. I close this pr.

@hamdouni hamdouni closed this Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants