You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While poking around in the code, I found some old logic that appears to append to an array without end. At the time, my question was whether the user of the array -- the underlying library -- was managing the size by pruning; I now believe that it does not. Since the data being added is quite small, the effect is not noticed except over long running periods. I left gotop running in multiple VMs over the course of nearly a month, and confirmed that the memory use was substantially larger than on start up. While I don't know that the data array(s) in the widgets are the cause of this, they're a likely suspect.
This is not new; this is ineherited code. The behavior could be new since the data arrays are owned by the underlying TUI library and that could have changed; however, as far as I know this has been an issue with gotop since it started using the library.
There's a TODO in the code at the point I noticed it. This ticket is to investigate further:
Dig down into the TUI library and see if it's doing any data management
If not, add pruning logic
If so, then start down the profiling path.
The text was updated successfully, but these errors were encountered:
While poking around in the code, I found some old logic that appears to append to an array without end. At the time, my question was whether the user of the array -- the underlying library -- was managing the size by pruning; I now believe that it does not. Since the data being added is quite small, the effect is not noticed except over long running periods. I left gotop running in multiple VMs over the course of nearly a month, and confirmed that the memory use was substantially larger than on start up. While I don't know that the data array(s) in the widgets are the cause of this, they're a likely suspect.
This is not new; this is ineherited code. The behavior could be new since the data arrays are owned by the underlying TUI library and that could have changed; however, as far as I know this has been an issue with gotop since it started using the library.
There's a TODO in the code at the point I noticed it. This ticket is to investigate further:
The text was updated successfully, but these errors were encountered: