-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JS Widgets as Shortcodes (Post Elements) with Shortcode UI (via Shortcake) #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to also be used for the Post Element browser in the editor.
… expected inside Shortcode UI window.
…widgets Fixes JS error due to customize-preview-widgets getting enqueued as well erroneously
…eature/shortcake-integration
westonruter
changed the title
WIP: Add JS Widgets as Shortcodes (Post Elements) with Shortcode UI (via Shortcake)
Add JS Widgets as Shortcodes (Post Elements) with Shortcode UI (via Shortcake)
Feb 17, 2017
This is ready for final testing and merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\WP_JS_Widget::$icon_name
gets exported to an inlinestyle
rules to apply to the widgets listed in the customizer.Ensure that widget can be previewed via shortcake and drafted in post content.(Irrelevant since the widget instance data is inline.)widget-form.css
so that elements will appear as expected, and not like this:Fixes #11.