Added mechanism to specify a constant for affiliate ID #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the Extensions page. Fixes #482.
| * @return string A query string of the format '?ref=1', where 1 is the affiliate ID | ||
| */ | ||
| function get_affiliate() { | ||
| return ( defined( 'WP_STREAM_AFFILIATE_ID' ) ? '?ref=' . urlencode( WP_STREAM_AFFILIATE_ID ) : '' ); |
There was a problem hiding this comment.
@Japh Since the affiliate ID should always be a positive integer, I we should sanitized it this way:
return ( defined( 'WP_STREAM_AFFILIATE_ID' ) && is_int( WP_STREAM_AFFILIATE_ID ) ) ? sprintf( '?ref=%d', absint( WP_STREAM_AFFILIATE_ID ) ) : null;…d in wp-config.php
* Point to expirimental PHPCS and WPCS for rulset subsets * Introduce config file for managing Travis before_script environment * Remove phpcs.ruleset.xml since we're referencing a core ruleset See xwp/wp-dev-lib#30
Conflicts: includes/extensions.php
|
Travis is happy, I'm happy. If everyone else is happy, let's merge. |
|
@lukecarbis Did you test and confirm that it works? |
|
Yes - tested and works. |
|
👍 |
lukecarbis
added a commit
that referenced
this pull request
May 2, 2014
Added mechanism to specify a constant for affiliate ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be used in the Extensions page. Fixes #482.