Issue 309: Theme Header and Background changes are not being logged #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
March 8, 2014 21:25
This reverts commit 62f94dc.
|
@powelski This is looking quite nice so far! Thank you. However, I have noticed that when changes are made to images, two records are always created: I think the additional "Data" record might be redundant here. What do you think? |
| 'permalink' => __( 'Permalinks', 'stream' ), | ||
| 'wp_stream' => __( 'Stream', 'stream' ), | ||
| 'custom-background' => __( 'Custom Background', 'stream' ), | ||
| 'custom-header' => __( 'Custom Header', 'stream' ), |
There was a problem hiding this comment.
@powelski These slugs should probably being using underscores instead of dashes, e.g. custom_header
|
@fjarrett I added method to provide ignored option keys and I put image data there, both for header and background. They are no longer logged: |
|
@powelski Can we also ensure that an action link is provided for these new fields? |
Conflicts: connectors/settings.php
Conflicts: classes/connector.php connectors/settings.php
frankiejarrett
added a commit
that referenced
this pull request
Mar 11, 2014
Issue 309: Theme Header and Background changes are not being logged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #309