Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix offset warning in Slack alert when there is no custom logo #1522

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

tharsheblows
Copy link
Contributor

Fixes #1371 .

This does a slight amount of refactoring to make the logic clearer as well as fix the array offset error.

It also adds in wp-content/db.php to the gitignore file in local/public so if you add Query Monitor then remove it, you don't accidentally commit it

Checklist

  • Project documentation has been updated to reflect the changes in this pull request, if applicable.
  • I have tested the changes in the local development environment (see contributing.md).
  • I have added phpunit tests.

Release Changelog

  • Fix: PHP Warning about offset error in Slack Alert

@tharsheblows tharsheblows added this to the 4.0.1 milestone Jul 25, 2024
Copy link
Contributor

@delawski delawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @tharsheblows 🙌

@delawski delawski merged commit 79f1344 into develop Jul 26, 2024
2 checks passed
@delawski delawski deleted the fix/1371-array-offset branch July 26, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants