Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing nonce check to uninstall action #1431

Closed
wants to merge 29 commits into from
Closed

Add missing nonce check to uninstall action #1431

wants to merge 29 commits into from

Commits on Apr 20, 2023

  1. Add missing nonce check to uninstall action

    @schlessera
    schlessera committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    804ff73 View commit details
    Browse the repository at this point in the history

  2. Add testing for multisite uninstall

    @schlessera
    schlessera committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    1760447 View commit details
    Browse the repository at this point in the history

  3. Fix broken SQL in multisite user meta removal

    @schlessera
    schlessera committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    67e3716 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Make the caller responsible for all the necessary permissions checks

    @kasparsd
    kasparsd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    3554488 View commit details
    Browse the repository at this point in the history

  2. Don't call it twice

    @kasparsd
    kasparsd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    1d4d3ed View commit details
    Browse the repository at this point in the history

  3. Add helper keys for individual checks

    @kasparsd
    kasparsd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    08ce5cd View commit details
    Browse the repository at this point in the history

  4. Test pure deletion in isolation

    @kasparsd
    kasparsd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    45d3908 View commit details
    Browse the repository at this point in the history

  5. Test that the DB driver can purge the tables in isolation

    @kasparsd
    kasparsd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    521ba8b View commit details
    Browse the repository at this point in the history

  6. Inherit the default behaviour

    @kasparsd
    kasparsd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    1ced5be View commit details
    Browse the repository at this point in the history

  7. Move the controller checks to the admin class

    @kasparsd
    kasparsd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    fdd6183 View commit details
    Browse the repository at this point in the history

  8. Be specific about the active user role for each test

    @kasparsd
    kasparsd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    4d74dcb View commit details
    Browse the repository at this point in the history

  9. Test that uninstall action callback is registered

    @kasparsd
    kasparsd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    e70a92b View commit details
    Browse the repository at this point in the history

  10. Don't login user by default

    @kasparsd
    kasparsd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    3167688 View commit details
    Browse the repository at this point in the history

  11. Add the uninstall controller tests

    @kasparsd
    kasparsd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    a787668 View commit details
    Browse the repository at this point in the history

  12. Add as a helper for re-use

    @kasparsd
    kasparsd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    21cd213 View commit details
    Browse the repository at this point in the history

  13. Use the shared exception catcher

    @kasparsd
    kasparsd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    bdbee96 View commit details
    Browse the repository at this point in the history

  14. Do the uninstall whenever called

    @kasparsd
    kasparsd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    cd73f14 View commit details
    Browse the repository at this point in the history

  15. Use the helper

    @kasparsd
    kasparsd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    9d120b1 View commit details
    Browse the repository at this point in the history

  16. Remove a duplicate of test_purge_storage()

    @kasparsd
    kasparsd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    04324a5 View commit details
    Browse the repository at this point in the history

  17. No harm in keeping the redirect

    @kasparsd
    kasparsd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    ad1e0c1 View commit details
    Browse the repository at this point in the history

  18. Test wp_stream_uninstall success

    @kasparsd
    kasparsd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    1ab2249 View commit details
    Browse the repository at this point in the history

  19. Use a local and direct reference

    @kasparsd
    kasparsd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    ba6c72f View commit details
    Browse the repository at this point in the history

  20. We no longer return the Uninstall instance

    @kasparsd
    kasparsd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    920ea2f View commit details
    Browse the repository at this point in the history

  21. Fix the namespace reference

    @kasparsd
    kasparsd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    41bc5ad View commit details
    Browse the repository at this point in the history

  22. Prevent subsites from deleting ALL network data

    @kasparsd
    kasparsd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    029b0d7 View commit details
    Browse the repository at this point in the history

  23. Allow only super admins to purge tables on multisites

    @kasparsd
    kasparsd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    af37a5f View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. Make it resolve the class by lookup instead

    @kasparsd
    kasparsd committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    62dc627 View commit details
    Browse the repository at this point in the history

  2. Ensure emails are unique per role 

    Co-authored-by: Alain Schlesser <[email protected]>
    @kasparsd @schlessera
    kasparsd and schlessera authored Apr 24, 2023
    Configuration menu
    Copy the full SHA
    8053bd6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix/cve-2022-43490' of github.com:xwp/stream into fix/c… 

    …ve-2022-43490
    @kasparsd
    kasparsd committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    688972f View commit details
    Browse the repository at this point in the history