-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update audit log message for comments transitioning status #1430
Update audit log message for comments transitioning status #1430
Conversation
This adds the post title to the audit log text for comments that are transitioning status, to be consistent with the other messages in the comments connector.
a143d50
to
547cb03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Please see the one suggestion inline the pull request!
@goldenapples Looks like the missing CI runs for this pull request did actually introduce a regression for the unit tests: https://github.com/xwp/stream/actions/runs/6178185169/job/16770933181?pr=1448#step:9:60 Would you be able to create a follow-up pull request to fix that test? stream/tests/tests/connectors/test-class-connector-comments.php Lines 420 to 422 in 4979211
|
Fix tests after comment translation change in #1430
Updates the test assertion for this method to match the new log output.
Just opened a PR to fix the unit test, #1450. I didn't run tests locally, and they're not set to run on forks, but I updated the assertion to match the expected output. |
Fix unit test which was broken in #1430
This adds the post title to the audit log text for comments that are transitioning status, to be consistent with the other messages in the comments connector.
Describe your approach and how it fixes the issue.
Checklist
contributing.md
).Release Changelog
Release Checklist
master
branch.readme.txt
.stream.php
.Stable tag
inreadme.txt
.classes/class-plugin.php
.Change
[ ]
to[x]
to mark the items as done.