Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-22571: Backlinks update changes an absolute reference to the moved page into one relative to the current wiki #3654

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

surli
Copy link
Member

@surli surli commented Nov 18, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-22571

Changes

Description

  • Use default serializer if the wiki is present in a link, not the compact serializer
  • Provide unit test and integration test to cover this

Clarifications

  • Right now the oracle to guess if the link contains a wiki is by using a regex, but I'm not very happy with this, we should probably find a better way for detecting it.

Screenshots & Video

Executed Tests

Run tests in modules:

  • xwiki-platform-flamingo-skin-test-docker:
    •  2 failures to fix in DeletePageIT
  • xwiki-platform-refactoring-default

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • 16.10.x only

@surli surli self-assigned this Nov 19, 2024
@surli surli marked this pull request as draft November 19, 2024 17:35
…ved page into one relative to the current wiki

  * Use default serializer if the wiki is present in a link, not the
    compact serializer
  * Provide unit test and integration test to cover this
…ved page into one relative to the current wiki

  * Fix DeletePageIT tests
…ved page into one relative to the current wiki

  * Provide relative EntityResourceReference resolvers for
    ResourceReference and use those to determine if an entity reference
contains a wiki part or not
  * WIP: need to check / improve actual implem of the resolvers and add
    test / doc
…ved page into one relative to the current wiki

  * Provide implementations for  relative
    ResourceReferenceEntityReference resolvers and tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant