XWIKI-21631: Tour generates a bottom scroll-bar, when items are created near the margins

[Sereza7]

Jira URL

https://jira.xwiki.org/browse/XWIKI-21631

Changes

Description

• Removed a useless class from the popover-navigation
• Overwrote a style from bootstrap-tour with a precise selector

Clarifications

• The combinaison of negative margin with positive padding was the cause of the bug.
• I removed the .row class from bootstrap that brought the negative margin.
• I overwrote the .popover-navigation class from bootstrap-tour that brought the padding.
• The selector I used to overwrite is very specific, this new style rules should not collide and break any other components or customization.

Screenshots & Video

Before the PR, it looked the same, but on Firefox 128, I could see a horizontal scrollbar trying to scroll would twitch with a blank line on the right and end up as non scrolled.
After the changes proposed in this PR were applied on my local instance, here are the results:

There is no more scrollbar. The style of the box did not change.

Executed Tests

Only manual tests, see above.
From what I can see, the pageObject used in tests is not broken:

xwiki-platform/xwiki-platform-core/xwiki-platform-tour/xwiki-platform-tour-test/xwiki-platform-tour-test-pageobjects/src/main/java/org/xwiki/tour/test/po/PageWithTour.java

Lines 122 to 123 in 330657a

	getDriver().findElement(By.xpath("//div[contains(@class, 'popover-navigation')]//a[@id='bootstrap_tour_end']"))
	.click();

The xpath selectors do not rely on the "style only" .row class but only on .popover-navigation, which is kept the same.
I did not run any automated tests.

Expected merging strategy

• Prefers squash: Yes
• Backport on branches:
  • 16.4.X
  • 15.10.X