XWIKI-21115: @breadcrumb-color doesn't apply to links in the Breadcrumb #3536
Conversation
…own links * Updated the color used by the links in the breadcrumb dropdown.
* Updated the color used by the links in the breadcrumb bar.
Sereza7
added
backport stable-15.10.x
| color: @breadcrumb-color; | ||
| &:hover, &:focus { |
There was a problem hiding this comment.
What about the :active and :visited states?
There was a problem hiding this comment.
There's no specific style for the active and visited states. Checked directly on my local distribution.
Note that if there was, we'd probably need to override any style added by the visited state, because it doesn't make sense for the buttons next to the links.
|
Technically, this looks good. However, looking at this pull request and the issue again I wonder if there is an agreement that these colors should actually be applied to the links. I think it would be good to have small proposal to agree about this. The issue also mentions introducing new color variables for the links as an alternative from what I understand. |
|
Started https://forum.xwiki.org/t/breadcrumb-links-color/15735 👍 |
|
Setting it as a draft:
If option 1. is picked (the one currently implemented), make sure to correct the looks of this solution with the default Iceberg, |
Sereza7
removed
the
backport stable-15.10.x
Jira URL
https://jira.xwiki.org/browse/XWIKI-21115
Changes
Description
Screenshots & Video
Here, I set the color
@breadcrumb-colorto a lightgreen in order to be able to see it easily.Before the changes proposed in this PR:
After the changes proposed in this PR (also changed the
@breadcrumb-active-colorto a dark green to make sure it still works well together):Executed Tests
Manual tests, see above. This is a style change only, and it doesn't change the UI layout, so it should be pretty safe for automated tests.
Expected merging strategy