Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This fixed incorrect language info token generation #6

Merged
merged 2 commits into from
Aug 19, 2023

Conversation

taomin597715379
Copy link
Contributor

  • Correction currency string token parsing result
  • Updates the unit tests, workflow, and the founding info

PR Details

This fixed incorrect language info token generation.

Motivation and Context

For example, the characters ANG should be parsed a currency string token in the number format code [$ANG], but NFP parse it as a language info token currently, this change list fixed it.

How Has This Been Tested

Add new test cases for this changes, and updated the existing test cases.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • [ x I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Correction currency string token parsing result
- Updates the unit tests, workflow, and the founding info
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2023

Codecov Report

Merging #6 (6aebee2) into main (2d5eeba) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          465       465           
=========================================
  Hits           465       465           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
nfp.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xuri xuri added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 19, 2023
Copy link
Owner

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri xuri merged commit dc951e3 into xuri:main Aug 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants