More selective detection of breaking/dangerous enum value changes #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #18 by only flagging enum value additions as breaking if the enum is used in output types and only flagging enum value removals as breaking if the enum is used in input types.
I tried out a different way of testing schema changes in
GraphQL::SchemaComparator::Diff::SchemaTest
that colocates the change path and message and adds testing of the change level. I'm happy to convert thetest_changes_kitchensink
methood to use this pattern too if you want.