Fix field argument removed message #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @bessey. Want to just scope this PR down to the argument fix so we can ship that first? Then try and solve the second issue. |
bessey
force-pushed
the
change-message-fixes
branch
from
f0c3869
to
8be42c1
Compare
|
Yep no problem, I dropped the final commit and left it on another branch |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begins the fixing of #50
I was able to fix one case easily, but I am not sure where to start with the other case, so I have stopped at writing a test proving the issue for now.
Since the test failure output is pretty unreadable, here's some help
If I could get some assistance in actually fixing this 2nd issue, it would be appreciated