1503 #4
Closed
1503 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Report
|
… if comment is null (apache#1653) ### What changes were proposed in this pull request? remove reserveProperties logic from CreateTableRequest since reserved properties is handled by property system ### Why are the changes needed? 1. when build IcebergTable, comment equals to null is checked when comment added to properties . ``` if (null != comment) { icebergTable.properties.putIfAbsent(ICEBERG_COMMENT_FIELD_NAME, comment); } ``` 2. when build CreateTableRequest, the previous implement remove all reserved properties from property map including comment, and then add comment to map, the bug happens, not checking the null, but this overall code is redundant Fix: apache#1546 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? add UT
…tabases. (apache#1608) ### What changes were proposed in this pull request? Filtering out the display of jdbc system databases. ### Why are the changes needed? Fix: apache#1607 ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? UT/IT --------- Co-authored-by: Clearvive <[email protected]>
### What changes were proposed in this pull request? remove sweetalert2 ### Why are the changes needed? Fix: apache#1535 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? N/A
…che#1657) ### What changes were proposed in this pull request? Improve tree view synchronization and add table loading. https://github.com/datastrato/gravitino/assets/17310559/4e84481c-389a-4686-aa5c-2b7ade70aaf5 ### Why are the changes needed? Fix: apache#1477 fix tree view sync Fix: apache#1605 fix table data fill when error Fix: apache#1606 add table fetch loading Fix: apache#1619 dup of 1605 Fix: apache#1644 dup of 1605 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? N/A
…ioning in common module (apache#1677) ### What changes were proposed in this pull request? rename package name from partitions to partitioning in common module ### Why are the changes needed? Fix: apache#1675 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing tests
xunliu
pushed a commit
that referenced
this pull request
Jul 3, 2024
…che#4006) ### What changes were proposed in this pull request? Frontend integration test failed in certain headless environment, like the ec2 in aws. ### Why are the changes needed? Frontend integration test failed due to the following error: ``` MetalakePageTest > initializationError FAILED org.openqa.selenium.WebDriverException: unknown error: Chrome failed to start: exited abnormally. (chrome not reachable) (The process started from chrome location /actions-runner/_work/gravitino-test/gravitino-test/gravitino/integration-test/build/chrome/chrome-linux/chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.) Build info: version: '3.141.59', revision: 'e82be7d358', time: '2018-11-14T08:17:03' System info: host: 'ip-172-31-5-251', ip: '172.31.5.251', os.name: 'Linux', os.arch: 'amd64', os.version: '6.5.0-1020-aws', java.version: '1.8.0_412' Driver info: driver.version: ChromeDriver remote stacktrace: #0 0x561b8bc79869 <unknown> #1 0x561b8bc14383 <unknown> #2 0x561b8b9f6ca3 <unknown> #3 0x561b8ba1a286 <unknown> #4 0x561b8ba157cd <unknown> #5 0x561b8ba4f11d <unknown> #6 0x561b8ba49963 <unknown> #7 0x561b8ba1fe36 <unknown> #8 0x561b8ba20fd5 <unknown> #9 0x561b8bc41f90 <unknown> #10 0x561b8bc53d80 <unknown> ``` ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? <img width="1492" alt="image" src="https://github.com/datastrato/gravitino/assets/154112360/3e16870e-ad51-4677-aec5-8e8be0c68f9b">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test passed.
init
What changes were proposed in this pull request?
(Please outline the changes and how this PR fixes the issue.)
Why are the changes needed?
(Please clarify why the changes are needed. For instance,
Fix: # (issue)
Does this PR introduce any user-facing change?
(Please list the user-facing changes introduced by your change, including
How was this patch tested?
(Please test your changes, and provide instructions on how to test it: