Add analyzer and fixer for test classes nested in generic classes #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current build failures are not caused by your PR (I have added another PR to verify this). I'm investigating to see if I can figure out what's going on. |
|
Looking like .NET SDK 7.0.400 is to blame, as it's bringing in a new version of I can reproduce it locally with that installed inside WSL. Using .NET SDK 6 instead of 7 seems to fix it. Just running a pass on my PR to verify. |
|
Opened a bug: microsoft/vstest#4657 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes xunit/xunit#2528
Adds analyzer and fixer to prevent the error:
System.ArgumentException: Cannot create an instance of Tests+A'1+B[T] because Type.ContainsGenericParameters is true.The analyzer includes a check for tests in the base classes if the derived class does not directly contain tests, and limits the search to a depth of 3 classes in case of circular dependencies.