-
Notifications
You must be signed in to change notification settings - Fork 80
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
879b81d
commit 124b22a
Showing
1 changed file
with
21 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
124b22a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did this change solve my problem? You're just awaiting the debugger. Still calling the same code if waitForDebugger is true. Which I guess it is in my case?
#415
124b22a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not every invocation of DebuggerProcessLauncher needs to wait for the debugger (in particular, we call into the test process with
-assemblyInfo
just to get the metadata about the test assembly). A change we made in 0.3.0 shifted around these calls such that the new launcher is seeing all invocations, not just ones that should wait for the debugger. So we need to inspect the switches that are being passed to only try to debug attach when we see-waitForDebugger
.124b22a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that explains things. Thanks