Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: setup pre-commit #63

Merged
merged 2 commits into from
Jan 29, 2023
Merged

ci: setup pre-commit #63

merged 2 commits into from
Jan 29, 2023

Conversation

sbrugman
Copy link
Collaborator

No description provided.

@sbrugman sbrugman mentioned this pull request Jan 19, 2023
Draft
xuhdev
xuhdev reviewed Jan 23, 2023
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
xuhdev
xuhdev reviewed Jan 23, 2023
View reviewed changes
Copy link
Owner

@xuhdev xuhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the merge conflict -- I decided to make another release before I jump into your PRs. The conflict should be pretty straightforward to resolve as they occur in removed files.

Everything else looks good to me other than the comments.

.pre-commit-config.yaml Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@sbrugman
Copy link
Collaborator Author

Changes are now minimal, should be good to go.

xuhdev
xuhdev approved these changes Jan 29, 2023
View reviewed changes
Copy link
Owner

@xuhdev xuhdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good now, thanks!

@xuhdev xuhdev merged commit 0e57dea into xuhdev:master Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xuhdev xuhdev xuhdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrugman @xuhdev