New version

[sbrugman]

Major update with new feature and dealing with technical debt. Would be awesome if you're open to merging and releasing this!

• (feat) Implement a check for __main__ (Check __name__ == ‘__main__’? #2)
• (test) refactor and added some cases
• (ci) replace appveyor with github actions for testing
• (refactor) migrate to pyproject.toml
• (refactor) use pre-commit for linting

[sbrugman]

Note that appveyor is replaced by Github Actions, for which all tests pass:
https://github.com/sbrugman/flake8-executable/actions/runs/3913083580

[sbrugman]

@xuhdev Kindly requesting for a review

[xuhdev]

Thank you for your contribution! It's actually pretty hard to review because so many different changes are mixed together in one giant PR. There are some changes that I think should be discussed separately (e.g., deleting renovate-lint.yml). However, most of the PR should be looking good. Would you mind breaking down the PR a bit so we can get them reviewed separately?

Thank you again!

[sbrugman]

Good point, I'll split up the changes

[sbrugman]

@xuhdev The commits are now rearranged into meaningful and more atomic changes.
Code review is possible per commit. (I've not created individual PRs to prevent conflicts of the readme).

Moreover, I've reverted the removal of renovate and editorconfig so that those changes can be discussed separately.
(renovate is currently broken, but a fix is in another PR)

[xuhdev]

Thanks again for the PR! I'll try to review one commit per day due to my lack of time.

Actually, you can create stacked PRs -- one PR starts on another PR's branch, and so on. In this way, there won't be conflict. I can give you permission to create branch and change non-master branches in this repo so things should be easier.

[xuhdev]

The reason that I had this tox.ini here is to avoid overdepending on a particular CI system. The appveyor file is pretty minimal and the heavy work is done in this tox.ini file.

[sbrugman]

Ok, in that case let us stick with tox and make it work with Github Actions. The benefit of this would be a shorter feedback loop, while maintaining portability.

[sbrugman]

Will split up PR

[xuhdev]

I'm OK with using pre-commit, but it looks like pre-commit is not good at managing multiple python versions. I saw some people suggest using pre-commit in tox to get the best of both worlds, e.g., https://stackoverflow.com/a/71023703/1150462. What do you think? Hong

…

On January 19, 2023 12:43:48 AM PST, Simon Brugman ***@***.***> wrote: @sbrugman commented on this pull request. > @@ -1,59 +0,0 @@ -# Copyright (c) 2020 Hong Xu ***@***.***> Understandable. With all linting wrapped in pre-commit the Github Actions workflow is also relatively simple and could be easily ported to another CI. We could still wrap them in tox if you prefer.

[sbrugman]

I agree. In the other PRs I have integrated pre-commit with tox