Skip to content

Commit

Permalink
build: rename tools workflow and add undici to it
Browse files Browse the repository at this point in the history
The workflow already updates Corepack, which is a `deps`, not a `tool`.
Add subsystem and label variables to the matrix to better control the
automated pull requests and add undici to the updated deps.

PR-URL: nodejs#42246
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
  • Loading branch information
targos authored and xtx1130 committed Apr 25, 2022
1 parent a2ada36 commit 8506d3b
Showing 1 changed file with 23 additions and 5 deletions.
28 changes: 23 additions & 5 deletions .github/workflows/tools.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Tools update
name: Tools and deps update
on:
schedule:
# Run once a week at 00:05 AM UTC on Sunday.
Expand All @@ -7,14 +7,16 @@ on:
workflow_dispatch:

jobs:
tools-update:
tools-deps-update:
if: github.repository == 'nodejs/node'
runs-on: ubuntu-latest
strategy:
fail-fast: false # Prevent other jobs from aborting if one fails
matrix:
include:
- id: eslint
subsystem: tools
label: tools
run: |
cd tools
NEW_VERSION=$(npm view eslint dist-tags.latest)
Expand All @@ -24,10 +26,14 @@ jobs:
./update-eslint.sh
fi
- id: corepack
subsystem: deps
label: dependencies
run: |
make corepack-update
echo "NEW_VERSION=$(node deps/corepack/dist/corepack.js --version)" >> $GITHUB_ENV
- id: lint-md-dependencies
subsystem: tools
label: tools
run: |
cd tools/lint-md
npm ci
Expand All @@ -44,6 +50,8 @@ jobs:
make lint-md-rollup
fi
- id: doc
subsystem: tools
label: tools
run: |
cd tools/doc
npm ci
Expand All @@ -57,6 +65,16 @@ jobs:
npm install --ignore-scripts $NEW_VERSION
npm install --ignore-scripts
fi
- id: undici
subsystem: deps
label: dependencies
run: |
NEW_VERSION=$(npm view undici dist-tags.latest)
CURRENT_VERSION=$(node -p "require('./deps/undici/src/package.json').version")
if [ "$NEW_VERSION" != "$CURRENT_VERSION" ]; then
echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
./tools/update-undici.sh
fi
steps:
- uses: actions/checkout@v2
with:
Expand All @@ -69,6 +87,6 @@ jobs:
author: Node.js GitHub Bot <[email protected]>
body: This is an automated update of ${{ matrix.id }} to ${{ env.NEW_VERSION }}.
branch: actions/tools-update-${{ matrix.id }} # Custom branch *just* for this Action.
commit-message: 'tools: update ${{ matrix.id }} to ${{ env.NEW_VERSION }}'
labels: tools
title: 'tools: update ${{ matrix.id }} to ${{ env.NEW_VERSION }}'
commit-message: '${{ matrix.subsystem }}: update ${{ matrix.id }} to ${{ env.NEW_VERSION }}'
labels: ${{ matrix.label }}
title: '${{ matrix.subsystem }}: update ${{ matrix.id }} to ${{ env.NEW_VERSION }}'

0 comments on commit 8506d3b

Please sign in to comment.