Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add arm64 helm client retrieval support #562

Merged
merged 1 commit into from
Apr 10, 2024
Merged

add arm64 helm client retrieval support #562

merged 1 commit into from
Apr 10, 2024

Conversation

laDok8
Copy link
Contributor

@laDok8 laDok8 commented Apr 3, 2024

Please make sure your PR meets the following requirements:

  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is formatted, imports ordered, code compiles and tests are passing
  • Code is self-descriptive and/or documented

@laDok8 laDok8 requested a review from mnovak1 April 3, 2024 17:15
@mnovak1
Copy link
Contributor

mnovak1 commented Apr 8, 2024

@laDok8 LGTM, do you have any CI run?

@laDok8
Copy link
Contributor Author

laDok8 commented Apr 9, 2024

I'm afraid we haven't got any arm workers available to give that a try. I've been attempting it within an arm docker container (AWS is also a possibility). However, I could supply x86 run: PR & master

@mnovak1 mnovak1 merged commit 5150cf6 into xtf-cz:master Apr 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simkam simkam simkam approved these changes

@mnovak1 mnovak1 Awaiting requested review from mnovak1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laDok8 @mnovak1 @simkam