Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for the issue when tar executed in docker container #555

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Workaround for the issue when tar executed in docker container #555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/src/main/java/cz/xtf/core/helm/ConfiguredVersionHelmBinaryPathResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,11 @@ private String unpackHelmClientArchive(final Path archivePath, final boolean del
Objects.requireNonNull(archivePath);

try {
// --no-same-owner argument is added for the docker container execution where tar gets wrong ownership information
// due to the context of the builder
List<String> args = Stream
.of("tar", "-xf", archivePath.toAbsolutePath().toString(), "-C",
getProjectHelmDir().toAbsolutePath().toString())
getProjectHelmDir().toAbsolutePath().toString(), "--no-same-owner")
simkam marked this conversation as resolved.
Show resolved Hide resolved
.collect(Collectors.toList());
ProcessBuilder pb = new ProcessBuilder(args);

Expand Down