New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle secretKeyRef in ContainerBuilder #547

Merged

mnovak1 merged 1 commit into xtf-cz:master from tommaso-borgato:fix-secretKeyRef

May 24, 2023

Contributor

tommaso-borgato commented May 24, 2023 •

edited

Loading

This MR add the option to use secretKeyRef, besides configMapKeyRef, in DeploymentConfig generated by ContainerBuilder, e.g.:

        - name: KC_DB_USERNAME
          valueFrom:
            secretKeyRef:
              name: postgresql
              key: database-user
        - name: KC_DB_PASSWORD
          valueFrom:
            secretKeyRef:
              name: postgresql
              key: database-password

Please make sure your PR meets the following requirements:

Pull Request contains a description of the changes
Pull Request does not include fixes for multiple issues/topics
Code is formatted, imports ordered, code compiles and tests are passing
Code is self-descriptive and/or documented


          Handle secretKeyRef in ContainerBuilder

5de1dd3

mnovak1 mentioned this pull request

configMapKeyRef and secretKeyRef: name and key are inverted #548

Closed

mnovak1 approved these changes

View reviewed changes

Contributor

mnovak1 commented May 24, 2023

LGTM, merging. Thanks for the fix.

mnovak1 merged commit 0ed7dc1 into xtf-cz:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet