Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record files from one Before* method failure to same directory #524

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

mocenas
Copy link
Contributor

@mocenas mocenas commented Feb 9, 2023

Change OpenShiftRecorder to store logs from single Before* method failure into same directory. Currently it generates random integer, for directory name, every time writing a file. Resulting in storing every *.log file into separate directory.

This MR generates unique identifier every time a openshift state is stored and uses it as identifier for all files.

Changes behaviour from #504

Please make sure your PR meets the following requirements:

  • Pull Request contains a description of the changes
  • Pull Request does not include fixes for multiple issues/topics
  • Code is formatted, imports ordered, code compiles and tests are passing
  • Code is self-descriptive and/or documented

@mocenas
Copy link
Contributor Author

mocenas commented Feb 9, 2023

cc @mnovak1 @fabiobrz

Copy link
Contributor

@fabiobrz fabiobrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mocenas! Yeah, I noticed the same behavior couple of days ago. I am approving the changes here, since they seem just correct to me, but I haven't a way to test them today.

@mnovak1 mnovak1 merged commit 964c823 into xtf-cz:master Feb 10, 2023
@mnovak1
Copy link
Contributor

mnovak1 commented Feb 10, 2023

@mocenas , LGTM and thanks for the PR.

@mocenas mocenas deleted the change_openshift_recorder_dirs branch February 10, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants