Skip builds also for disabled test classes #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnovak1
reviewed
Aug 25, 2022
junit5/src/test/java/cz/xtf/junit5/listeners/ManagedBuildPrebuilderTest.java
Show resolved
Hide resolved
simkam
approved these changes
Aug 25, 2022
Condition check needed to be extracted to the extra method to allow testing it.
jbliznak
force-pushed
the
skip-builds-for-disabled-classes
branch
from
82b7a14
to
b3cf8de
Compare
mnovak1
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, when class is annotated with
@SkipForor@SinceVersionand these annotations result in test class being skipped, we also skip pre-building of configured builds for that class (introduced in #277).This PR extends the check to also skip the build when test class is annotated with JUnit
@Disabledannotation which further optimizes the execution.Also some tests were added to verify the previous and enhanced behaviour.