[#456][#462] refactor logic determining cluster version and logic downloading oc binar #465
Conversation
…nd logic downloading oc binary fixes xtf-cz#456 fixes xtf-cz#462 - cache openshift version (loaded either from configuration or from cluster) - download oc binary from - mirror.openshift.com (if cluster version is known) - cluster (if version is uknown assume OCP4 and download it from cluster)o - binary download supports stable (default), latest, candidate and fast channels if configured version is in major.minor format only Some public methods from `OpenShifts` class are marked as deprecated, they aren't now use internally by XTF and I believe they shouldn't have been public.
…erBinder"' during tests SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder". SLF4J: Defaulting to no-operation (NOP) logger implementation SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
|
@mcarlett you might want to review this as well since you added binary cache feature. I'm changing it a lot, but it should work exactly the same way. I have marked public caching methods in |
@simkam thanks for the refactoring, I think we can remove deprecated methods and dedicated tests as well. Moreover, you can remove the unused deprecated constants in |
|
Thanks for the review. Since those methods are public and they were in the last release, I would keep them deprecated for few releases before we remove them. I know there is low chance that somebody is using them, but it is a best practice after all. |
fixes #456
fixes #462
Some public methods from
OpenShiftsclass are marked as deprecated, they aren't now used internally by XTF and I believe they shouldn't have been public.Some tests are included, the rest (major.minor only version, no version, no permissions to detect cluster version ...) tested manually.