Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly cancel event when in mouse mode #849

Merged
merged 1 commit into from
Aug 8, 2017
Merged

Properly cancel event when in mouse mode #849

merged 1 commit into from
Aug 8, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Aug 6, 2017

Fixes #848

I added the TODO as the cancel function should be removed imo.

@Tyriar Tyriar added this to the 3.0.0 milestone Aug 6, 2017
@Tyriar Tyriar self-assigned this Aug 6, 2017
@Tyriar Tyriar requested a review from parisk August 6, 2017 20:03
@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.306% when pulling 45157d8 on Tyriar:848_cancel_event_on_wheel into 687a5e2 on sourcelair:v3.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.306% when pulling 45157d8 on Tyriar:848_cancel_event_on_wheel into 687a5e2 on sourcelair:v3.

@Tyriar Tyriar added breaking-change Breaks API and requires a major version bump and removed breaking-change Breaks API and requires a major version bump labels Aug 8, 2017
@Tyriar Tyriar merged commit 8a17ac1 into xtermjs:v3 Aug 8, 2017
@Tyriar Tyriar deleted the 848_cancel_event_on_wheel branch August 8, 2017 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parisk parisk parisk approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Tyriar @coveralls @parisk