WIP: Trying to fix #5176 #5272

AnouarTouati · 2025-01-06T07:53:57Z

This draft is WIP attempt to fix #5176 @jerch

Search is done in chunks , in alternating manner up/down so the region the user sees first will be done first.
Decorators/markers 's disposal is also done in chunks in the background(a new search can start without waiting for this to finish).
Added debounce to the search function.
Search is now cancel-able

This is obviously a breaking change.
I tried to go with the conservative approach to keep the code changes to a minimum. But, I had to re-write most of the code.

If this is the direction you want the code to go in. I can keep working on this and maintaining the search addon from now on.
Also ignore the commits I was experimenting with stuff. Will squash them later.

2025-01-06.02-40-30.mp4

Tyriar · 2025-01-06T12:40:19Z

Adding responses to #5176 (comment) here.

Why does the cache have TTL ?

This is to aid in incremental searches

I experimented with making the search return a small set. release the main thread to render the result and then go and get the full result. i did this with a setTimeout. It helped a lot with the UX.

Something we want to keep is the highlighting of results in the "overview ruler":

Limiting these results too heavily will hurt the UX by not showing additional results. Make sure you add the overview ruler in the demo when working on this:

I noticed that "incremental" search only serves to do the following :
Suppose you have A B D C D in the terminal
Search for C to select it
Then search for D and it selects the second D.
Is this intentional ?

If I'm understanding you correctly, searching for CD second should only check if there is a D after the already existing C:

This is by design, incremental search means we can avoid doing much of the work, provided regex is not enabled which I think disables incremental completely.

Maybe another solution is to count the matches but only apply the decorators to the visible lines and a few hidden ones on top and bottom ?

The overview ruler is again an important piece here, see this result which is after running tree on Windows:

There are 19 results, and every one of these is represented in the overview ruler, allowing the user to know immediately how far back the term(s) are.

Tyriar

Looks promising! 👏

Tyriar · 2025-01-06T12:43:39Z

addons/addon-search/src/SearchAddon.ts

+  /**
+   * Number of matches in each chunk
+   */
+  private _chunkSize: number = 200;
+  /**
+   *  Time in ms
+   *  1 ms seems to work fine as we just need to let other parts of the code to take over
+   *  and return here when their work is done
+   */
+  private _timeBetweenChunkOperations = 1;
+
+  /**
+   * This should be high enough so not to trigger a lot of searches
+   * and subsequently a lot of canceled searches which clean up their own
+   * decorations and cause flickers
+   */
+  private _debounceTimeWindow = 300;
+  /**
+   *  Using this mainly for resizing event
+   */
+  private _longerDebounceTimeWindow = 1000;


There's actually a perfect helper for just this scenario in the main code:

https://github.com/Tyriar/xterm.js/blob/18c9eb196010ec082ad56adf7040ed2dca5fd391/src/common/TaskQueue.ts#L104-L109

This will let you continue to search until the deadline is reached, essentially scaling the solution to high end CPUs that can handle searching a lot more immediately instead of the arbitrary 200 line chunk limit. This is how we draw ascii glyphs to "warm up" the texture atlas without doing any of this optional work in a blocking manner.

https://github.com/Tyriar/xterm.js/blob/18c9eb196010ec082ad56adf7040ed2dca5fd391/src/browser/renderer/shared/TextureAtlas.ts#L118-L129

For your scenario it's important work that the user is waiting on, not optional, so PriorityTaskQueue is more appropriate. It works much the same, just it's backed by setTimeout, not requestIdleCallback.

Here is what I understood and correct me if I am wrong.
I will be en-queuing call back functions (Tasks) that process X number of lines. The task queue will run as many tasks as possible until we exceed the time limit at which point it yields, then do a new setTimeout to start processing of next batch of Tasks.

https://github.com/Tyriar/xterm.js/blob/18c9eb196010ec082ad56adf7040ed2dca5fd391/src/common/TaskQueue.ts#L104-L109

About the race condition comment. I think it arises from line 71 this._idleCallback = undefined; which in my opinion should be removed and inserted above line 95 this.start() that way new enqueue calls wont trigger new setTimeouts.

addons/addon-search/src/SearchAddon.ts

AnouarTouati · 2025-01-06T18:49:47Z

Something we want to keep is the highlighting of results in the "overview ruler":
Limiting these results too heavily will hurt the UX by not showing additional results. Make sure you add the overview ruler in the demo when working on this

I am currently highlighting all of the matches so this will not be a problem.
In the future I will highlight only the the matches that are in the viewport. and highlight everything on the overview ruler.

AnouarTouati · 2025-01-06T19:18:04Z

If I'm understanding you correctly, searching for CD second should only check if there is a D after the already existing C
This is by design, incremental search means we can avoid doing much of the work, provided regex is not enabled which I think disables incremental completely.

No, this is what the incremental flag is doing

then replace D with B in the search bar (dont backspace. Do Ctrl + A and overwrite)

Notice that the second B is selected.
matches before D are not considered for the first select.

That's all it does. It does not help performance.

I removed this behavior.
I will implement an actual incremental search in the future.

Broke regex search

Moved constants to an Enum

Tyriar · 2025-01-06T20:10:53Z

Notice that the second B is selected.
matches before D are not considered for the first select.

I'd have to play around with it, we just want to make sure it's consistent

and fixed multipe highlighting of regex matches

…eal with returning -1 on max highlight reached or about firing without decorations option set.

…ger modified

…on. 11 tests of 12 pass

AnouarTouati

I removed the "incremental" functionality while working on the code. Do I need to put back to pass these tests? Or have it incremental as in getting a subset of the previous search result i.e, only search inside in the previous set of matches instead of the whole buffer/terminal.

AnouarTouati · 2025-01-19T17:59:55Z

addons/addon-search/test/SearchAddon.test.ts

+  // test('Incremental Find Previous', async () => {
+  //   await ctx.proxy.writeln(`package.jsonc\n`);
+  //   await ctx.proxy.write('package.json pack package.lock');
+  //   await ctx.page.evaluate(`window.search.findPrevious('pack', {incremental: true})`);
+  //   let selectionPosition: { start: { x: number, y: number }, end: { x: number, y: number } } = (await ctx.proxy.getSelectionPosition())!;
+  //   let line: string = await (await ctx.proxy.buffer.active.getLine(selectionPosition.start.y))!.translateToString();
+  //   // We look further ahead in the line to ensure that pack was selected from package.lock
+  //   deepStrictEqual(line.substring(selectionPosition.start.x, selectionPosition.end.x + 8), 'package.lock');
+  //   await ctx.page.evaluate(`window.search.findPrevious('package.j', {incremental: true})`);
+  //   selectionPosition = (await ctx.proxy.getSelectionPosition())!;
+  //   deepStrictEqual(line.substring(selectionPosition.start.x, selectionPosition.end.x + 3), 'package.json');
+  //   await ctx.page.evaluate(`window.search.findPrevious('package.jsonc', {incremental: true})`);
+  //   // We have to reevaluate line because it should have switched starting rows at this point
+  //   selectionPosition = (await ctx.proxy.getSelectionPosition())!;
+  //   line = await (await ctx.proxy.buffer.active.getLine(selectionPosition.start.y))!.translateToString();
+  //   deepStrictEqual(line.substring(selectionPosition.start.x, selectionPosition.end.x), 'package.jsonc');
+  // });
+  // test('Incremental Find Next', async () => {
+  //   await ctx.proxy.writeln(`package.lock pack package.json package.ups\n`);
+  //   await ctx.proxy.write('package.jsonc');
+  //   await ctx.page.evaluate(`window.search.findNext('pack', {incremental: true})`);
+  //   let selectionPosition: { start: { x: number, y: number }, end: { x: number, y: number } } = (await ctx.proxy.getSelectionPosition())!;
+  //   let line: string = await (await ctx.proxy.buffer.active.getLine(selectionPosition.start.y))!.translateToString();
+  //   // We look further ahead in the line to ensure that pack was selected from package.lock
+  //   deepStrictEqual(line.substring(selectionPosition.start.x, selectionPosition.end.x + 8), 'package.lock');
+  //   await ctx.page.evaluate(`window.search.findNext('package.j', {incremental: true})`);
+  //   selectionPosition = (await ctx.proxy.getSelectionPosition())!;
+  //   deepStrictEqual(line.substring(selectionPosition.start.x, selectionPosition.end.x + 3), 'package.json');
+  //   await ctx.page.evaluate(`window.search.findNext('package.jsonc', {incremental: true})`);
+  //   // We have to reevaluate line because it should have switched starting rows at this point
+  //   selectionPosition = (await ctx.proxy.getSelectionPosition())!;
+  //   line = await (await ctx.proxy.buffer.active.getLine(selectionPosition.start.y))!.translateToString();
+  //   deepStrictEqual(line.substring(selectionPosition.start.x, selectionPosition.end.x), 'package.jsonc');
+  // });


Commented out "Incremental" test.

AnouarTouati · 2025-01-19T18:00:24Z

addons/addon-search/test/SearchAddon.test.ts

+    //     test('should fire with correct event values (incremental)', async () => {
+    //       await ctx.page.evaluate(`
+    //         window.calls = [];
+    //         window.search.onDidChangeResults(e => window.calls.push(e));
+    //       `);
+    //       await ctx.proxy.write('d abc aabc d');
+    //       deepStrictEqual(await ctx.page.evaluate(`window.search.findNext('a', { incremental: true, decorations: { activeMatchColorOverviewRuler: '#ff0000' } })`), true);
+    //       deepStrictEqual(await ctx.page.evaluate('window.calls'), [
+    //         { resultCount: 3, resultIndex: 0 }
+    //       ]);
+    //       deepStrictEqual(await ctx.page.evaluate(`window.search.findNext('ab', { incremental: true, decorations: { activeMatchColorOverviewRuler: '#ff0000' } })`), true);
+    //       deepStrictEqual(await ctx.page.evaluate('window.calls'), [
+    //         { resultCount: 3, resultIndex: 0 },
+    //         { resultCount: 2, resultIndex: 0 }
+    //       ]);
+    //       deepStrictEqual(await ctx.page.evaluate(`window.search.findNext('abc', { incremental: true, decorations: { activeMatchColorOverviewRuler: '#ff0000' } })`), true);
+    //       deepStrictEqual(await ctx.page.evaluate('window.calls'), [
+    //         { resultCount: 3, resultIndex: 0 },
+    //         { resultCount: 2, resultIndex: 0 },
+    //         { resultCount: 2, resultIndex: 0 }
+    //       ]);
+    //       deepStrictEqual(await ctx.page.evaluate(`window.search.findNext('abc', { incremental: true, decorations: { activeMatchColorOverviewRuler: '#ff0000' } })`), true);
+    //       deepStrictEqual(await ctx.page.evaluate('window.calls'), [
+    //         { resultCount: 3, resultIndex: 0 },
+    //         { resultCount: 2, resultIndex: 0 },
+    //         { resultCount: 2, resultIndex: 0 },
+    //         { resultCount: 2, resultIndex: 1 }
+    //       ]);
+    //       deepStrictEqual(await ctx.page.evaluate(`window.search.findNext('d', { incremental: true, decorations: { activeMatchColorOverviewRuler: '#ff0000' } })`), true);
+    //       deepStrictEqual(await ctx.page.evaluate('window.calls'), [
+    //         { resultCount: 3, resultIndex: 0 },
+    //         { resultCount: 2, resultIndex: 0 },
+    //         { resultCount: 2, resultIndex: 0 },
+    //         { resultCount: 2, resultIndex: 1 },
+    //         { resultCount: 2, resultIndex: 1 }
+    //       ]);
+    //       deepStrictEqual(await ctx.page.evaluate(`window.search.findNext('abcd', { incremental: true, decorations: { activeMatchColorOverviewRuler: '#ff0000' } })`), false);
+    //       deepStrictEqual(await ctx.page.evaluate('window.calls'), [
+    //         { resultCount: 3, resultIndex: 0 },
+    //         { resultCount: 2, resultIndex: 0 },
+    //         { resultCount: 2, resultIndex: 0 },
+    //         { resultCount: 2, resultIndex: 1 },
+    //         { resultCount: 2, resultIndex: 1 },
+    //         { resultCount: 0, resultIndex: -1 }
+    //       ]);


Commented out "Incremental" test.

AnouarTouati · 2025-01-19T18:01:39Z

addons/addon-search/test/SearchAddon.test.ts

+    // test('should fire with correct event values (incremental)', async () => {
+    //   await ctx.page.evaluate(`
+    //     window.calls = [];
+    //     window.search.onDidChangeResults(e => window.calls.push(e));
+    //   `);
+    //   await ctx.proxy.write('d abc aabc d');
+    //   deepStrictEqual(await ctx.page.evaluate(`window.search.findPrevious('a', { incremental: true, decorations: { activeMatchColorOverviewRuler: '#ff0000' } })`), true);
+    //   deepStrictEqual(await ctx.page.evaluate('window.calls'), [
+    //     { resultCount: 3, resultIndex: 2 }
+    //   ]);
+    //   deepStrictEqual(await ctx.page.evaluate(`window.search.findPrevious('ab', { incremental: true, decorations: { activeMatchColorOverviewRuler: '#ff0000' } })`), true);
+    //   deepStrictEqual(await ctx.page.evaluate('window.calls'), [
+    //     { resultCount: 3, resultIndex: 2 },
+    //     { resultCount: 2, resultIndex: 1 }
+    //   ]);
+    //   deepStrictEqual(await ctx.page.evaluate(`window.search.findPrevious('abc', { incremental: true, decorations: { activeMatchColorOverviewRuler: '#ff0000' } })`), true);
+    //   deepStrictEqual(await ctx.page.evaluate('window.calls'), [
+    //     { resultCount: 3, resultIndex: 2 },
+    //     { resultCount: 2, resultIndex: 1 },
+    //     { resultCount: 2, resultIndex: 1 }
+    //   ]);
+    //   deepStrictEqual(await ctx.page.evaluate(`window.search.findPrevious('abc', { incremental: true, decorations: { activeMatchColorOverviewRuler: '#ff0000' } })`), true);
+    //   deepStrictEqual(await ctx.page.evaluate('window.calls'), [
+    //     { resultCount: 3, resultIndex: 2 },
+    //     { resultCount: 2, resultIndex: 1 },
+    //     { resultCount: 2, resultIndex: 1 },
+    //     { resultCount: 2, resultIndex: 0 }
+    //   ]);
+    //   deepStrictEqual(await ctx.page.evaluate(`window.search.findPrevious('d', { incremental: true, decorations: { activeMatchColorOverviewRuler: '#ff0000' } })`), true);
+    //   deepStrictEqual(await ctx.page.evaluate('window.calls'), [
+    //     { resultCount: 3, resultIndex: 2 },
+    //     { resultCount: 2, resultIndex: 1 },
+    //     { resultCount: 2, resultIndex: 1 },
+    //     { resultCount: 2, resultIndex: 0 },
+    //     { resultCount: 2, resultIndex: 1 }
+    //   ]);
+    //   deepStrictEqual(await ctx.page.evaluate(`window.search.findPrevious('abcd', { incremental: true, decorations: { activeMatchColorOverviewRuler: '#ff0000' } })`), false);
+    //   deepStrictEqual(await ctx.page.evaluate('window.calls'), [
+    //     { resultCount: 3, resultIndex: 2 },
+    //     { resultCount: 2, resultIndex: 1 },
+    //     { resultCount: 2, resultIndex: 1 },
+    //     { resultCount: 2, resultIndex: 0 },
+    //     { resultCount: 2, resultIndex: 1 },
+    //     { resultCount: 0, resultIndex: -1 }
+    //   ]);
+    // });
+    // test('should fire with more than 1k matches', async () => {
+    //   await ctx.page.evaluate(`
+    //     window.calls = [];
+    //     window.search.onDidChangeResults(e => window.calls.push(e));
+    //   `);
+    //   const data = ('a bc'.repeat(10) + '\\n\\r').repeat(150);
+    //   await ctx.proxy.write(data);
+    //   strictEqual(await ctx.page.evaluate(`window.search.findPrevious('a', { decorations: { activeMatchColorOverviewRuler: '#ff0000' } })`), true);
+    //   deepStrictEqual(await ctx.page.evaluate('window.calls'), [
+    //     { resultCount: 1000, resultIndex: -1 }
+    //   ]);
+    //   strictEqual(await ctx.page.evaluate(`window.search.findPrevious('a', { decorations: { activeMatchColorOverviewRuler: '#ff0000' } })`), true);
+    //   deepStrictEqual(await ctx.page.evaluate('window.calls'), [
+    //     { resultCount: 1000, resultIndex: -1 },
+    //     { resultCount: 1000, resultIndex: -1 }
+    //   ]);
+    //   strictEqual(await ctx.page.evaluate(`window.search.findPrevious('bc', { decorations: { activeMatchColorOverviewRuler: '#ff0000' } })`), true);
+    //   deepStrictEqual(await ctx.page.evaluate('window.calls'), [
+    //     { resultCount: 1000, resultIndex: -1 },
+    //     { resultCount: 1000, resultIndex: -1 },
+    //     { resultCount: 1000, resultIndex: -1 }
+    //   ]);
+    // });


Commented out "Incremental" test.

AnouarTouati

This is the API changes needed for async search.

AnouarTouati · 2025-01-19T18:13:03Z

addons/addon-search/typings/addon-search.d.ts

-     * When decorations are enabled, fires when
-     * the search results change.
-     * @returns -1 for resultIndex when the threshold of matches is exceeded.
+     * Fired everytime search progresses; until the search completes.
+     * @property {number} resultIndex - not final until seachedCompleyed is true.
+     * @property {number} resultCount - not final until searchCompleted is true.
+     * @property {boolean} searchCompleted.
+     * @returns  an IDisposable to stop listening.
     */
-    readonly onDidChangeResults: IEvent<{ resultIndex: number, resultCount: number }>;
+    readonly onDidChangeResults: IEvent<{ resultIndex: number, resultCount: number, searchCompleted: boolean }>;
  }
 }


Do I need to add another property (boolean) for when the matches exceed the highlight limit?

AnouarTouati · 2025-01-19T18:19:39Z

addons/addon-search/src/SearchAddon.ts

+  private _fireResults(): void {
+    this._onDidChangeResults.fire({ resultIndex:this._currentMatchIndex, resultCount: this._matches.length,searchCompleted: this._searchCompleted });
  }
+  private *_chunkSearchGenerator(term: string): Generator<{direction: string,chunkSize: number}>{

-  private _fireResults(searchOptions?: ISearchOptions): void {
-    if (searchOptions?.decorations) {
-      let resultIndex = -1;
-      if (this._selectedDecoration.value) {
-        const selectedMatch = this._selectedDecoration.value.match;
-        for (let i = 0; i < this._highlightDecorations.length; i++) {


Fire whenever we have a new chunk regardless of searchOptions.decorations is set or not.

AnouarTouati · 2025-01-19T18:23:32Z

addons/addon-search/test/SearchAddon.test.ts

-    deepStrictEqual(await ctx.page.evaluate(`window.search.findNext('$^1_3{}test$#')`), true);
+    await ctx.page.evaluate(`window.search.findNext('$^1_3{}test$#')`);


Find not longer returns a boolean for search result since it is now async. so I changed all tests to not expect a boolean. added getSelection assertion instead, when needed.

AnouarTouati · 2025-01-19T18:31:13Z

addons/addon-search/test/SearchAddon.test.ts

-      deepStrictEqual(await ctx.page.evaluate('window.calls'), [
-        { resultCount: 2, resultIndex: 1 }
-      ]);
+      await ctx.proxy.write('\\x1b[CHi Hi Hi');
+      await ctx.page.evaluate(`window.search.findPrevious('h', { decorations: { activeMatchColorOverviewRuler: '#ff0000' } })`);
+      await timeout(TIMEOUT);
+      deepStrictEqual(await ctx.page.evaluate('window.calls[window.calls.length-1]'),
+        { resultCount: 3, resultIndex: 0, searchCompleted: true }


We are not firing once per search, but multiple per search (on each chunk ), so we need to get the last entry which should have searchCompleted true.

AnouarTouati · 2025-01-19T19:36:55Z

I fixed all the bugs I encountered, except for the flicker.
When the search result changes e.g., from "fixes" to "fixe" like in the video below.
The new decorations being rendered and old ones being removed might overlap, because I am not synchronizing that.
It should only flicker once, instead it is flicking multiple times.
Any hints of why that is happening ?

async.mp4

Also I tested forcing it to remove all decorations before a new search starts, and finding all matches before rending it (by setting CHUNK_SIZE and LINE_LIMIT to equal highlight limit), this fixes the issue.

sync.mp4

Tyriar requested changes Jan 6, 2025

View reviewed changes

Tyriar reviewed Jan 6, 2025

View reviewed changes

addons/addon-search/src/SearchAddon.ts Outdated Show resolved Hide resolved

AnouarTouati added 8 commits January 6, 2025 14:57

Re-write of search addon (squashed)

693069d

Code clean up

f1d3dc0

fixed an issue were regex fails to detect matches

13f29e5

Fixed blocking render when matches are sparse or non.

e2c679f

Broke regex search

Removed test

b6e0be0

Converted cancelSearchSignal to a regular global variable boolean.

b8759fe

Moved constants to an Enum

small fix

5678dff

enabled overview ruler by default in the demo

6ecf521

AnouarTouati force-pushed the search-start-at-middle-of-view branch from c71ef1b to 6ecf521 Compare January 6, 2025 20:02

AnouarTouati added 15 commits January 6, 2025 16:08

fixed regex not working

c6417eb

fixed regex special chars being lower cases.

35b4c54

and fixed multipe highlighting of regex matches

small refactor

0589529

Migrating old test to work for new code

d8199cd

5 test now pass

b473aa8

8 tests now pass

d7235fe

11 tests now pass

589c1fa

12 test now pass. there are 8 left that are either "incremental" or d…

956f3ba

…eal with returning -1 on max highlight reached or about firing without decorations option set.

updated JSDoc

1866d39

removed chache clearing on fresh regex search as line cache is no lon…

fff5266

…ger modified

give more time for one of the tests to do a search

271940b

search now uses PriorityTaskQueue

1e7f27d

clear decorations now uses PriorityTaskQueue

cd5ee68

added LINE_LIMIT constant

c116277

improved upward search performance

2e1d345

AnouarTouati added 9 commits January 14, 2025 00:08

fix scroll search test

9a16ad3

replaced old buffer to string conversion with more clear implementati…

35fa7cf

…on. 11 tests of 12 pass

fixe find previous

8b305eb

modified search test to fit new api

0ad9911

modified search test fit new api

2cc65a6

fix emojis not recognized as wide grapheme

2dbf4fd

small refactor

0a4b06b

reafactor

baee8cc

lowered running time of tests

bce2bb1

This comment was marked as duplicate.

Sign in to view

AnouarTouati commented Jan 19, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Trying to fix #5176 #5272

WIP: Trying to fix #5176 #5272

AnouarTouati commented Jan 6, 2025 •

edited

Loading

Tyriar commented Jan 6, 2025

Tyriar left a comment

Tyriar Jan 6, 2025

AnouarTouati Jan 7, 2025

AnouarTouati commented Jan 6, 2025

AnouarTouati commented Jan 6, 2025

Tyriar commented Jan 6, 2025

This comment was marked as duplicate.

AnouarTouati left a comment •

edited

Loading

AnouarTouati Jan 19, 2025

AnouarTouati Jan 19, 2025

AnouarTouati Jan 19, 2025

AnouarTouati left a comment

AnouarTouati Jan 19, 2025

AnouarTouati Jan 19, 2025

AnouarTouati Jan 19, 2025

AnouarTouati Jan 19, 2025

AnouarTouati commented Jan 19, 2025

		deepStrictEqual(await ctx.page.evaluate(`window.search.findNext('$^1_3{}test$#')`), true);
		await ctx.page.evaluate(`window.search.findNext('$^1_3{}test$#')`);

WIP: Trying to fix #5176 #5272

Are you sure you want to change the base?

WIP: Trying to fix #5176 #5272

Conversation

AnouarTouati commented Jan 6, 2025 • edited Loading

Tyriar commented Jan 6, 2025

Tyriar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AnouarTouati commented Jan 6, 2025

AnouarTouati commented Jan 6, 2025

Tyriar commented Jan 6, 2025

This comment was marked as duplicate.

AnouarTouati left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AnouarTouati left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AnouarTouati commented Jan 19, 2025

AnouarTouati commented Jan 6, 2025 •

edited

Loading

AnouarTouati left a comment •

edited

Loading