Start @playwright/test migration #4735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Up to 50% savings from the new integration test jobs 🎉
|
|
Actually the gain is a little nuanced as the addon tests are only done in the old tests now. Here's an example of without the PR:
|
|
I didn't migrate all the tests to use the proxy as it doesn't need to happen to make the change. The addon tests also have not been brought over yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the successor to #3460, the plan is to add proper support for these types of tests and have both types in the codebase simultaneously. Instead of trying to migrate all unit tests at once, we can do it parts at a time and any new tests can be added using the new method.
This is a WIP and will only get merged when the integration feels solid.
Part of #3446
Part of #3326