-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move image addon to base repo #4577
Conversation
@Tyriar Thats interesting - since I removed the internal worker I dont need to patch |
@Tyriar Read for review. The code is the same as the last patch release (0.4.2), except the license entries (all adjusted). |
@Tyriar Not sure whats going on with azure atm, both macos and windows runner give me different timeout issues. Tried to mitigate them somewhat, not sure if they are all gone now... |
@Tyriar Those timeout issues with heavy load CI runners are really nasty. Its a bit tricky to wait for the state change in the remote browser engine. Tried to replace several waits with |
Jesus, the failing tests are really annoying, all versions I tested above pass locally just fine, grrr. 🤯 |
@jerch good to merge when you're ready as this is all pretty separated from the core code. We have a few more changes from the old repo to include as well is all. |
@Tyriar I will go though your comments in jerch/xterm-addon-image#55 and transfer the missing changes here as well before merging. |
Moves the image addon code over to the base repo.
TODO: