-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render the cursor in the WebGL canvas #4568
Conversation
This also focused the manager's creation on renderer start up, to ensure blink works immediately.
Underline and bar cursors don't seem to update correctly atm |
Fixed the blue problem, was related to rgba format being used as rgb f64cb15 |
The light theme issue is actually a problem outside of this PR as the cursor colors don't get set in the theme so the defaults are used. |
This ensures underline/bar cursors get rendered
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xzfc great work on this! I made a few fixes and I think this is good to go
Just need to fix the tests:
|
#4082
The
RectangleRenderer
is updated not just to draw cell backgrounds, but the cursor as well (bar
andunderscore
cursors are 1px wide rectangles,blur
cursor consists of four 1px rectangles). The block cursor is implemented by changing cell attributes.The
CursorRenderLayer
is dropped.