Added optional case sensitive searching #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
requested changes
Sep 8, 2018
src/addons/search/SearchHelper.ts
Outdated
| const lowerTerm = term.toLowerCase(); | ||
| let searchIndex = lowerStringLine.indexOf(lowerTerm); | ||
| private _findInLine(term: string, y: number, caseSensitive: boolean): ISearchResult { | ||
| const stringLIne = this._terminal._core.buffer.translateBufferLineToString(y, true); |
alexr00
force-pushed
the
alexr00/caseSearch
branch
from
2a6aa25 to
16de86f
Compare
|
Conflicts resolved. |
Tyriar
reviewed
Sep 11, 2018
Tyriar
approved these changes
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1657