Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deleteChars not updating the view #1106

Merged
merged 1 commit into from
Nov 6, 2017
Merged

Fix deleteChars not updating the view #1106

merged 1 commit into from
Nov 6, 2017

Conversation

martin31821
Copy link
Contributor

@martin31821 martin31821 commented Nov 5, 2017

When deleting a character in a line and moving the cursor to
another line afterwards, the deletion is not rendered.

This commit adds the line where the character was deleted
to the refresh range to enforce an update.

Fixes #1110

When deleting a character in a line and moving the cursor to
another line afterwards, the deletion is not rendered.
This commit adds the line where the character was deleted
to the refresh range to enforce an update
@Tyriar
Copy link
Member

Tyriar commented Nov 5, 2017

Is there a bug that this fixes? Could you provide some repro steps if so?

@martin31821
Copy link
Contributor Author

There is no issue for this bug open at the moment. However it's perfectly reproducible:

  • Send 2 lines of text to the terminal using .write
  • Move the cursor into the first line
  • Send the following escape sequence: \e[B\e[P\e[A
  • As you can see, the terminal won't update the second line which is clearly a bug.

I'll prepare a fiddle to reproduce it.

@Tyriar
Copy link
Member

Tyriar commented Nov 6, 2017

Repro'd and created #1110

Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks for the PR 😃

@Tyriar Tyriar merged commit b0020fc into xtermjs:v3 Nov 6, 2017
@Tyriar Tyriar added this to the 3.0.0 milestone Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants