Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mousedown event should continue propagation when the terminal has a selection #913

Closed
Tyriar opened this issue Aug 24, 2017 · 0 comments
Closed

mousedown event should continue propagation when the terminal has a selection #913

Tyriar opened this issue Aug 24, 2017 · 0 comments
Assignees
@Tyriar
Labels
type/bug Something is misbehaving
Milestone
3.0.0

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 24, 2017

Causing this issue microsoft/vscode#32336

Right now we stop propagation if the terminal has a selection and the right button is pressed. This forces the context menu to fire which may not be desirable.
@Tyriar Tyriar added the type/bug Something is misbehaving label Aug 24, 2017
@Tyriar Tyriar added this to the 3.0.0 milestone Aug 24, 2017
@Tyriar Tyriar self-assigned this Aug 24, 2017
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Aug 24, 2017
@Tyriar
Allow mousedown even to propagate on right click
b706383 
Fixes xtermjs#913
@Tyriar Tyriar mentioned this issue Aug 24, 2017
Merged
Tyriar added a commit to Tyriar/xterm.js that referenced this issue Aug 24, 2017
@Tyriar
Allow mousedown even to propagate on right click
a71aa9b 
Fixes xtermjs#913
@Tyriar Tyriar mentioned this issue Sep 13, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
type/bug Something is misbehaving
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@Tyriar